fix(gdpr): explicit radering av ai_corrections/scan_jobs + S3-bilder vid DELETE /v1/me
- DELETE /v1/me soft-deletar users, så users-cascade fyrar aldrig. - Samlar distinkta bildnycklar från ai_corrections, ai_training_bank och scan_jobs och raderar dem via storage.deleteObject innan DB-radering. - S3-fel loggas och avbryter inte raderingen. - Raderar explicit ai_corrections (ai_training_bank cascadar) och scan_jobs. - Lägger till deleteObject i StorageService (mock + AWS/DeleteObjectCommand). - Uppdaterar docs/28-lärande-loop.md med faktisk mekanism och retention. - Tester: verifierar noll rader kvar och storage.deleteObject-anrop. Relaterat: skiva-1-fixrunda, blockerande GDPR-hål.
This commit is contained in:
Sven (AAMOS AI)
@@ -0,0 +1,216 @@
|
||||
import "./setup-env.js";
|
||||
import { describe, expect, it, beforeAll, afterAll, vi } from "vitest";
|
||||
import { eq, inArray } from "drizzle-orm";
|
||||
import { buildServer } from "../src/server.js";
|
||||
import { loadConfig } from "../src/config.js";
|
||||
import { createDatabase, closeDatabase, schema } from "@app/database";
|
||||
|
||||
describe("DELETE /v1/me — GDPR-radering", () => {
|
||||
const testDb = createDatabase(process.env.TEST_DATABASE_URL!);
|
||||
const config = loadConfig();
|
||||
let app: Awaited<ReturnType<typeof buildServer>>;
|
||||
|
||||
async function cleanupUser(email: string) {
|
||||
const existing = await testDb.db
|
||||
.select({ id: schema.users.id })
|
||||
.from(schema.users)
|
||||
.where(inArray(schema.users.email, [email, `deleted-${email}`]));
|
||||
for (const u of existing) {
|
||||
const corrections = await testDb.db
|
||||
.select({ id: schema.aiCorrections.id })
|
||||
.from(schema.aiCorrections)
|
||||
.where(eq(schema.aiCorrections.userId, u.id));
|
||||
if (corrections.length > 0) {
|
||||
await testDb.db
|
||||
.delete(schema.aiTrainingBank)
|
||||
.where(
|
||||
inArray(
|
||||
schema.aiTrainingBank.correctionId,
|
||||
corrections.map((r) => r.id),
|
||||
),
|
||||
);
|
||||
}
|
||||
await testDb.db.delete(schema.aiCorrections).where(eq(schema.aiCorrections.userId, u.id));
|
||||
await testDb.db.delete(schema.scanJobs).where(eq(schema.scanJobs.userId, u.id));
|
||||
await testDb.db.delete(schema.userConsents).where(eq(schema.userConsents.userId, u.id));
|
||||
await testDb.db.delete(schema.userPreferences).where(eq(schema.userPreferences.userId, u.id));
|
||||
await testDb.db.delete(schema.userCredentials).where(eq(schema.userCredentials.userId, u.id));
|
||||
await testDb.db.delete(schema.refreshTokens).where(eq(schema.refreshTokens.userId, u.id));
|
||||
await testDb.db.delete(schema.users).where(eq(schema.users.id, u.id));
|
||||
}
|
||||
}
|
||||
|
||||
async function registerUser(email: string) {
|
||||
const res = await app.inject({
|
||||
method: "POST",
|
||||
url: "/v1/auth/register",
|
||||
payload: { email, password: "Password123!", displayName: "GDPR Delete Test" },
|
||||
});
|
||||
const body = JSON.parse(res.body) as { accessToken: string };
|
||||
const token = body.accessToken;
|
||||
const userId = (JSON.parse(atob(token.split(".")[1]!)) as { sub: string }).sub;
|
||||
|
||||
await app.inject({
|
||||
method: "POST",
|
||||
url: "/v1/onboarding/quick-start",
|
||||
headers: { authorization: `Bearer ${token}` },
|
||||
payload: { goals: ["less_waste"], precisionMode: "simple" },
|
||||
});
|
||||
|
||||
return { token, userId };
|
||||
}
|
||||
|
||||
beforeAll(async () => {
|
||||
app = await buildServer(config);
|
||||
await app.ready();
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
await closeDatabase();
|
||||
await app.close();
|
||||
});
|
||||
|
||||
it("raderar ai_corrections, ai_training_bank, scan_jobs och tillhörande S3-bilder", async () => {
|
||||
const email = "gdpr-full-delete@example.invalid";
|
||||
await cleanupUser(email);
|
||||
const { token, userId } = await registerUser(email);
|
||||
|
||||
for (const kind of ["personalization", "anonymized_improvement", "image_training"] as const) {
|
||||
await testDb.db
|
||||
.insert(schema.userConsents)
|
||||
.values({ userId, kind, status: "granted" as const })
|
||||
.onConflictDoUpdate({
|
||||
target: [schema.userConsents.userId, schema.userConsents.kind],
|
||||
set: { status: "granted" as const },
|
||||
});
|
||||
}
|
||||
|
||||
const [scanJob] = await testDb.db
|
||||
.insert(schema.scanJobs)
|
||||
.values({
|
||||
userId,
|
||||
scanType: "fridge",
|
||||
jobType: "ANALYZE_FRIDGE_IMAGE",
|
||||
status: "awaiting_confirmation",
|
||||
s3Keys: ["fridge-scans/scan-a.jpg", "fridge-scans/scan-b.jpg"],
|
||||
})
|
||||
.returning();
|
||||
|
||||
const [correction] = await testDb.db
|
||||
.insert(schema.aiCorrections)
|
||||
.values({
|
||||
scanJobId: scanJob!.id,
|
||||
userId,
|
||||
taskType: "ANALYZE_FRIDGE_IMAGE",
|
||||
aiOutput: { raw: {} },
|
||||
userCorrection: { action: "accept" },
|
||||
imageS3Key: "fridge-scans/correction-a.jpg",
|
||||
consentSnapshot: { image_training: "granted", anonymized_improvement: "granted" },
|
||||
})
|
||||
.returning();
|
||||
|
||||
await testDb.db.insert(schema.aiTrainingBank).values({
|
||||
correctionId: correction!.id,
|
||||
scanJobId: scanJob!.id,
|
||||
taskType: "ANALYZE_FRIDGE_IMAGE",
|
||||
imageS3Key: "fridge-scans/training-a.jpg",
|
||||
proposal: { detectedName: "Mjölk" },
|
||||
action: "accept",
|
||||
corrected: { displayName: "Mjölk" },
|
||||
consentSnapshot: { image_training: "granted", anonymized_improvement: "granted" },
|
||||
});
|
||||
|
||||
const deleteSpy = vi.spyOn(app.storage, "deleteObject").mockResolvedValue(undefined);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "DELETE",
|
||||
url: "/v1/me",
|
||||
headers: { authorization: `Bearer ${token}` },
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
|
||||
const deletedKeys = deleteSpy.mock.calls.map((c) => c[0]).sort();
|
||||
expect(deletedKeys).toEqual(
|
||||
[
|
||||
"fridge-scans/scan-a.jpg",
|
||||
"fridge-scans/scan-b.jpg",
|
||||
"fridge-scans/correction-a.jpg",
|
||||
"fridge-scans/training-a.jpg",
|
||||
].sort(),
|
||||
);
|
||||
|
||||
const remainingCorrections = await testDb.db
|
||||
.select({ id: schema.aiCorrections.id })
|
||||
.from(schema.aiCorrections)
|
||||
.where(eq(schema.aiCorrections.userId, userId));
|
||||
expect(remainingCorrections).toHaveLength(0);
|
||||
|
||||
const remainingBank = await testDb.db
|
||||
.select({ id: schema.aiTrainingBank.id })
|
||||
.from(schema.aiTrainingBank)
|
||||
.innerJoin(
|
||||
schema.aiCorrections,
|
||||
eq(schema.aiTrainingBank.correctionId, schema.aiCorrections.id),
|
||||
)
|
||||
.where(eq(schema.aiCorrections.userId, userId));
|
||||
expect(remainingBank).toHaveLength(0);
|
||||
|
||||
const remainingScans = await testDb.db
|
||||
.select({ id: schema.scanJobs.id })
|
||||
.from(schema.scanJobs)
|
||||
.where(eq(schema.scanJobs.userId, userId));
|
||||
expect(remainingScans).toHaveLength(0);
|
||||
|
||||
const [user] = await testDb.db
|
||||
.select({ deletedAt: schema.users.deletedAt, email: schema.users.email })
|
||||
.from(schema.users)
|
||||
.where(eq(schema.users.id, userId))
|
||||
.limit(1);
|
||||
expect(user?.deletedAt).not.toBeNull();
|
||||
expect(user?.email).toContain("anonymized.invalid");
|
||||
|
||||
deleteSpy.mockRestore();
|
||||
await cleanupUser(email);
|
||||
});
|
||||
|
||||
it("fortsätter raderingen även om lagringen kastar för en bild", async () => {
|
||||
const email = "gdpr-storage-fail@example.invalid";
|
||||
await cleanupUser(email);
|
||||
const { token, userId } = await registerUser(email);
|
||||
|
||||
const [scanJob] = await testDb.db
|
||||
.insert(schema.scanJobs)
|
||||
.values({
|
||||
userId,
|
||||
scanType: "pantry",
|
||||
jobType: "ANALYZE_PANTRY_IMAGE",
|
||||
status: "awaiting_confirmation",
|
||||
s3Keys: ["pantry-scans/fail.jpg"],
|
||||
})
|
||||
.returning();
|
||||
|
||||
const deleteSpy = vi
|
||||
.spyOn(app.storage, "deleteObject")
|
||||
.mockRejectedValueOnce(new Error("S3 nere"))
|
||||
.mockResolvedValue(undefined);
|
||||
|
||||
const res = await app.inject({
|
||||
method: "DELETE",
|
||||
url: "/v1/me",
|
||||
headers: { authorization: `Bearer ${token}` },
|
||||
});
|
||||
|
||||
expect(res.statusCode).toBe(200);
|
||||
expect(deleteSpy).toHaveBeenCalledWith("pantry-scans/fail.jpg");
|
||||
|
||||
const remainingScans = await testDb.db
|
||||
.select({ id: schema.scanJobs.id })
|
||||
.from(schema.scanJobs)
|
||||
.where(eq(schema.scanJobs.userId, userId));
|
||||
expect(remainingScans).toHaveLength(0);
|
||||
|
||||
deleteSpy.mockRestore();
|
||||
await cleanupUser(email);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user